Detailed err message on wrong request url #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-bisonai
changed the title
nick-bisonai
changed the title
cli/src/utils.ts
Outdated
| return 200 === (await axios.get(url))?.status | ||
| } catch (e) { | ||
| console.error(`Orakl Network Fetcher [${url}] is down`) | ||
| if (!(await isValidUrl(url))) { |
There was a problem hiding this comment.
Just suggestion. I think we should be careful with capturing more than unnecessary amount code with try which might lead to code that is harder to read. Below, in the suggestion I move the try branch below isValidUrl which theoretically could lead to missing exception thrown by isValidUrl function, however, the function does not throw anything and only returns boolean.
export async function isOraklFetcherHealthy(url: string) {
if (!(await isValidUrl(url))) {
console.error('Invalid URL')
return false
}
try {
const response = await axios.get(url)
if (response.status === 200) {
return true
} else {
console.error(`Orakl Network Fetcher [${url}] is down. HTTP Status: ${response.status}`)
return false
}
} catch (error) {
console.error(
`An error occurred while checking the Orakl Network Fetcher [${url}]: ${error.message}`
)
return false
}
}There was a problem hiding this comment.
I totally agree with you, I will push again after fixing this
martinkersner
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when requested
cli fetcher activewith wrong host and port, it returned following messageOrakl Network Fetcher [${url}] is down.Now it checks if url is valid and returns
Invalid URLon wrong requestFixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment